Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preliminary back extension support #58

Merged
merged 10 commits into from
Dec 7, 2020

Conversation

JaroCamphuijsen
Copy link
Collaborator

@JaroCamphuijsen JaroCamphuijsen commented Dec 2, 2020

Continues the work in PR #56 to support the preliminary back extension of era5.
Addresses part of issue #54
Fixes #60

@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #58 (42f4e6e) into master (2c2dffd) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
+ Coverage   97.90%   98.06%   +0.15%     
==========================================
  Files           7        7              
  Lines         287      310      +23     
==========================================
+ Hits          281      304      +23     
  Misses          6        6              
Impacted Files Coverage Δ
era5cli/cli.py 96.73% <100.00%> (+0.48%) ⬆️
era5cli/fetch.py 98.42% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c2dffd...42f4e6e. Read the comment docs.

Copy link
Collaborator

@SarahAlidoost SarahAlidoost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JaroCamphuijsen nice work, I could download the monthly data with the different product types, too. Thanks for adding the tests. Feel free to merge this PR.

@JaroCamphuijsen JaroCamphuijsen merged commit afdea52 into master Dec 7, 2020
@JaroCamphuijsen JaroCamphuijsen deleted the preliminary-back-extension branch December 7, 2020 13:48
@JaroCamphuijsen JaroCamphuijsen restored the preliminary-back-extension branch December 14, 2020 20:11
@JaroCamphuijsen JaroCamphuijsen deleted the preliminary-back-extension branch December 14, 2020 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected behavior for --statistics flag
2 participants