Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove plugins #385

Merged
merged 19 commits into from
Oct 10, 2023
Merged

Remove plugins #385

merged 19 commits into from
Oct 10, 2023

Conversation

sverhoeven
Copy link
Member

@sverhoeven sverhoeven commented Oct 5, 2023 •
edited
Loading

Fixes #371

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@sverhoeven sverhoeven marked this pull request as ready for review October 6, 2023 07:23
BSchilperoort
BSchilperoort approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@BSchilperoort BSchilperoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! All plugin things seem to be removed. I did notice some outdated/broken links in the README.

.github/workflows/ci.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that you changed this to micromamba 🚀

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but somtimes the action fails with shared library errors

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd, I have not encountered that in Zampy's CI where we have a micromamba workflow.

README.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The readme says "More examples can be found in the documentation.", however I think that's not the case anymore right?

README.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Exposes simple interface to quickly get up and running"

link is broken

@BSchilperoort BSchilperoort mentioned this pull request Oct 9, 2023
Closed
@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sverhoeven sverhoeven merged commit e287ad5 into main Oct 10, 2023
5 checks passed
@sverhoeven sverhoeven deleted the plugin-less branch October 10, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BSchilperoort BSchilperoort BSchilperoort approved these changes

@Peter9192 Peter9192 Awaiting requested review from Peter9192

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move plugins to own repo
2 participants
@sverhoeven @BSchilperoort