Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tare feature #34

Merged
merged 5 commits into from
Aug 3, 2016
Merged

Add tare feature #34

merged 5 commits into from
Aug 3, 2016

Conversation

joewiz
Copy link
Member

@joewiz joewiz commented Jul 16, 2016

  • press the "Tare" button to establish a baseline from which to report subsequent results
  • the idea is to eliminate monex's own results from subsequent refreshes and help users focus on relevant results
  • uses actual statistics as baseline, plus some hard-coded ones to eliminate the "tare" functions themselves
  • press the "Clear Tare" button to return to normal behavior

Screenshot showing "Clear Tare"

This is functionally complete, but I would really like comments, and I may need to add some documentation to explain the feature.

- press the "Tare" button to establish a baseline from which to report subsequent results
- the idea is to eliminate monex's own results from subsequent refreshes and help users focus on relevant results
- uses actual statistics as baseline, plus some hard-coded ones to eliminate the "tare" functions themselves
- press the "Clear Tare" button to return to normal behavior
@claudius108
Copy link

This is very nice, we need it!

This is helpful to distinguish between the many similarly named files in apps these days, e.g., controller.xql and app.xql. Desktops have plenty of room in this column.
@joewiz
Copy link
Member Author

joewiz commented Jul 27, 2016

I've been trying to think of a more robust method of suppressing functions than the manual filtering the PR currently performs; see wolfgangmm@d546eb4#diff-ee16ce62bb3cc95ebe5fb49e819c73daR263.

How about either a pragma like (# exist:suppress-from-profiling-if-tare-enabled #) - to apply to a specific expression - or an option like declare option exist:suppress-from-profiling-if-tare-enabled to apply to an entire query?

I suppose I could avoid the line number issue by using starts-with() to check for the queries whose results I want to suppress. Really, I just need to drop 3 modules from the results: monex's app.xql, eXide's controller.xql (because of login checks), and the built-in persistent login module, login.xql.

Having thought this through out loud, I'll go ahead with the latter option and update the PR, but I'll leave the first idea here, should it prove useful.

avoids the problem of hard coding line numbers
restore trimming of entries > 60 characters, but for these, we show full path as a tooltip
@joewiz
Copy link
Member Author

joewiz commented Jul 27, 2016

Okay, there is no longer any hard coding of line numbers. With "tare" enabled, all queries/functions/indexes in monex's app.xql, eXide's controller.xql, and the persistent login module login.xql are suppressed from query profiling results. I also restored truncation of long source paths.

@wolfgangmm wolfgangmm merged commit 687ae31 into eXist-db:master Aug 3, 2016
@joewiz joewiz deleted the add-tare-feature branch January 30, 2017 18:15
@duncdrum
Copy link
Contributor

duncdrum commented Mar 14, 2018

I think this qualifies for a docs-outdated label 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants