Switch to maven build and enable Travis #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamretter
force-pushed
the
refactor/switch-to-maven-build
branch
from
6f57415
to
83823b1
Compare
adamretter
force-pushed
the
refactor/switch-to-maven-build
branch
from
61111f2
to
eafa632
Compare
dizzzz
approved these changes
Dec 17, 2018
duncdrum
requested changes
Dec 17, 2018
There was a problem hiding this comment.
thanks adam this is very helpful.
ok i tested and have two minor change requests:
- the top-level folder
indexes-test/should go intosrc/main/xar-resourcesit would keep it working before replacing it with an xqsuite test. (there is already two tests insrc/main/xar-resources/modules/suite.xql) - the image link on the readme should be changed to
src/main/xar-resources/resources/img/screenshot.png?raw=true
adamretter
force-pushed
the
refactor/switch-to-maven-build
branch
from
eafa632
to
e3debda
Compare
|
@duncdrum Okay I fixed those two things and rebased. Hopefully good now. |
duncdrum
approved these changes
Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now have a reproducible build!
Closes #62