feat: stable XAR upload and install #129
Conversation
- add options to readAll example - add explanations to app.* - consistent error handling examples - the examples should be more readable in general
BREAKING CHANGE: App installation is not compatible with exist 3.6.1! This is because the collection `/db/system/repo` does not exist. For installation to work reliably the XAR must be present in that collection (at least for existdb v4+).
|
As stable as XAR handling currently is, see eXist-db/exist#3598 |
- extract XQuery scripts into separate files - add type hints to exported methods - add and stabilize tests
There was a problem hiding this comment.
Looks good, although I m a bit worried about the dependency resolution, I remember some deeply broken instance in the past if a package is present but it’s dependencies can’t be found. Should we maybe perform a check if a dependency is declared, and either issue a warning, or more radically abort install of xars with dependencies?
|
@duncdrum Thanks for having a look! After a lot of testing this is the only real path to break it reproducibly: eXist-db/exist#3598 About dependency resolution and broken expath-repositories:
|
|
@duncdrum I stand corrected! |
|
@line-o did you check if you can restart the intended with the incomplete app installed? If that works we re in the clear, I seem to remember that was a big problem way back when. |
|
I decided to move forward and have dependency resolution in place. |
Call `repo:install-and-deploy-from-db` with package repository URL. - add defaultPackageRepo to app component. - add optional parameter `customPackageRepoUrl` to install method Add optional object "result" to typedef for NormalizedQueryResult. - adapt xquery return values - adapt tests
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
A real breakthrough. Finally XAR installation is stable.