Fix for https://github.com/eagletmt/ghcmod-vim/issues/30 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 11, 2013 16:57
to use newline as the line separator (rather than the default NULL) for ghc-mod expand.
Tell ghc-mod to use newline as the line separator, in place of its default NULL.
eagletmt
added a commit
that referenced
this pull request
Oct 15, 2013
|
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix is to explicitly tell ghc-mod to use newline as the line separator, in place of its default NULL. The requisite flag ("-b") is present in ghc-mod >= 2.1.2.
As I understand it, the issue is the result of ghc-mod issues/changes
ghc-mod expandincompatibility DanielG/ghc-mod#128In short: GHC 7.6 is sending the splices to ghc-mod via the logger rather than stderr, so that ghc-mod is inserting its own default line separator (NULL) rather than passing on GHC's.