Rename additional_containers to sidecars

Such containers are called "sidecars" nowadays.

examples/hello-autoscaling.jsonnet

@@ -58,7 +58,7 @@ local provide(name) = fileProvider(std.toString({ path: 'hello.env' }), name);
       MESSAGE: std.format('%s-san', provide('username')),
     },
   },
-  additional_containers: {
+  sidecars: {
     front: {
       image_tag: 'hako-nginx',
       memory: 32,

examples/hello-fargate.jsonnet

@@ -72,7 +72,7 @@ local awslogs = {
     },
     log_configuration: awslogs,
   },
-  additional_containers: {
+  sidecars: {
     front: {
       image_tag: 'hako-nginx',
       log_configuration: awslogs,

examples/hello-lb-v2.jsonnet

@@ -51,7 +51,7 @@ local provide(name) = fileProvider(std.toString({ path: 'hello.env' }), name);
       MESSAGE: std.format('%s-san', provide('username')),
     },
   },
-  additional_containers: {
+  sidecars: {
     front: {
       image_tag: 'hako-nginx',
       memory: 32,

examples/hello-lb.jsonnet

@@ -29,7 +29,7 @@ local provide(name) = fileProvider(std.toString({ path: 'hello.env' }), name);
       MESSAGE: std.format('%s-san', provide('username')),
     },
   },
-  additional_containers: {
+  sidecars: {
     front: {
       image_tag: 'hako-nginx',
       memory: 32,

examples/hello.jsonnet

@@ -25,7 +25,7 @@ local provide(name) = fileProvider(std.toString({ path: 'hello.env' }), name);
       MESSAGE: std.format('%s-san', provide('username')),
     },
   },
-  additional_containers: {
+  sidecars: {
     front: {
       image_tag: 'hako-nginx',
       memory: 32,

lib/hako/definition_loader.rb

@@ -18,24 +18,25 @@ def initialize(app, dry_run:)
     # @param [Array<String>, nil] with
     # @return [Hash<String, Container>]
     def load(tag, with: nil)
-      additional_containers = @app.definition.fetch('additional_containers', {})
+      # XXX: Load additional_containers for compatibility
+      sidecars = @app.definition.fetch('sidecars', @app.definition.fetch('additional_containers', {}))
       container_names = ['app']
       if with
         container_names.concat(with)
       else
-        container_names.concat(additional_containers.keys)
+        container_names.concat(sidecars.keys)
       end
 
-      load_containers_from_name(tag, container_names, additional_containers)
+      load_containers_from_name(tag, container_names, sidecars)
     end
 
     private
 
     # @param [String] tag
     # @param [Array<String>] container_names
-    # @param [Hash<String, Hash>] additional_containers
+    # @param [Hash<String, Hash>] sidecars
     # @return [Hash<String, Container>]
-    def load_containers_from_name(tag, container_names, additional_containers)
+    def load_containers_from_name(tag, container_names, sidecars)
       names = Set.new(container_names)
       containers = {}
       while containers.size < names.size
@@ -45,7 +46,7 @@ def load_containers_from_name(tag, container_names, additional_containers)
             when 'app'
               AppContainer.new(@app, @app.definition['app'].merge('tag' => tag), dry_run: @dry_run)
             else
-              Container.new(@app, additional_containers.fetch(name), dry_run: @dry_run)
+              Container.new(@app, sidecars.fetch(name), dry_run: @dry_run)
             end
 
           containers[name].links.each do |link|

spec/fixtures/yaml/default.yml

@@ -1,6 +1,6 @@
 app:
   image: app-image
-additional_containers:
+sidecars:
   front:
     type: nginx
     image_tag: front-image

spec/fixtures/yaml/default_with_links.yml

@@ -2,7 +2,7 @@ app:
   image: app-image
   links:
     - redis
-additional_containers:
+sidecars:
   redis:
     image_tag: redis
     links:

spec/fixtures/yaml/default_with_volumes_from.yml

@@ -2,7 +2,7 @@ app:
   image: app-image
   volumes_from:
     - source_container: redis
-additional_containers:
+sidecars:
   redis:
     image_tag: redis
     volumes_from: