Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge instead of overwriting #32

Closed
wants to merge 1 commit into from
Closed

Conversation

minois
Copy link

@minois minois commented Apr 5, 2017

If it gets merged instead of overwriting it will be more convenient.

sample

# sample.yml
・・・
  front:
    <<: !include common.yml
    env:
      CLIENT_MAX_BODY_SIZE: 12M
・・・

# common.yml 
・・・
env:
  LISTEN_UNIX: /tmp/unicorn/unicorn.sock
・・・

before

   "env"=>{"CLIENT_MAX_BODY_SIZE"=>"12M"}},

after

   "env"=>{"LISTEN_UNIX"=>"/tmp/unicorn/unicorn.sock", "CLIENT_MAX_BODY_SIZE"=>"12M"}},

@eagletmt
Copy link
Owner

eagletmt commented Apr 6, 2017

This change is too big incompatibility to accept.
What do you think of adding new tag like !merge ?

@minois
Copy link
Author

minois commented Apr 6, 2017

I see, I understood.
It seems good to make a new tag.

@eagletmt
Copy link
Owner

Hako now supports Jsonnet format #38 .
Merging mappings can be expressed easily by +: syntax sugar.
http://jsonnet.org/docs/tutorial.html

@eagletmt eagletmt closed this Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants