Support Service Discovery #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new parameter called service_discovery to the ecs scheduler. Because the type of the serviceRegistries parameter for CreateService API is Array [1], the service_discovery parameter is defined as an array even though currently ECS doesn't allow a service to have more than 1 service registries. [1]: https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_CreateService.html#ECS-CreateService-request-serviceRegistries
kaorimatz
force-pushed
the
support-service-discovery
branch
2 times, most recently
from
0f04e9c
to
6693fd0
Compare
ECS API allows us to create a service with a service registry in a public DNS namespace, but tasks stop with "The Service Discovery instance could not be registered." error.
kaorimatz
force-pushed
the
support-service-discovery
branch
from
120eb13
to
e35b0f1
Compare
kaorimatz
force-pushed
the
support-service-discovery
branch
from
e35b0f1
to
45a9623
Compare
eagletmt
reviewed
Dec 17, 2018
| namespace_id = service.fetch('namespace_id') | ||
| namespace = get_namespace(namespace_id) | ||
| if !namespace | ||
| raise "Service discovery namespace #{namespace_id} not found" |
There was a problem hiding this comment.
Please raise Hako::Error for generic errors
| # @param [Hash] expected_service | ||
| # @param [Aws::ServiceDiscovery::Types::ServiceSummary] actual_service | ||
| # @return [void] | ||
| def warn_unallowed_service_change(expected_service, actual_service) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new parameter called service_discovery to the ecs scheduler.
Because the type of the serviceRegistries parameter for CreateService
API is Array 1, the service_discovery parameter is defined as an array
even though currently ECS doesn't allow a service to have more than 1
service registries.