fix: isEmpty defaults to false

ealush · Mar 31, 2022 · 128311f · 128311f
1 parent 101e6f1
commit 128311f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/packages/n4s/src/rules/__tests__/isEmpty.test.ts b/packages/n4s/src/rules/__tests__/isEmpty.test.ts
@@ -45,5 +45,9 @@ describe('Tests isEmpty rule', () => {
     it('Should return true for NaN', () => {
       expect(isEmpty(NaN)).toBe(true);
     });
+
+    it('Should return false for a Symbol', () => {
+      expect(isEmpty(Symbol('hey'))).toBe(false);
+    });
   });
 });
diff --git a/packages/n4s/src/rules/isEmpty.ts b/packages/n4s/src/rules/isEmpty.ts
@@ -15,7 +15,7 @@ export function isEmpty(value: unknown): boolean {
     return lengthEquals(Object.keys(value as Record<string, unknown>), 0);
   }
 
-  return true;
+  return false;
 }
 
 export const isNotEmpty = bindNot(isEmpty);