Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n locale file builder - Issue 120 #141

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

YassSMR
Copy link
Contributor

@YassSMR YassSMR commented Apr 30, 2021

We had a hard time finding a bookstore that met the import requirements you mentioned.
But we finally found a library that allowed us to do so.

To do the translations, you have to download the xlsx file in the extension directory and then run the npm i18 script.

Fixes #120

Co-authored: @toto101230

Copy link
Owner

@ear1grey ear1grey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, though the use of Excel is a surprise.
For maintainability going forward we'll need two key changes.

  1. The code should read values directly from this spreadsheet using the Google sheets API. (We can set the sheet to be readable by anyone, so only named editors can amend it.)
  2. If any of the locales marked as ready does not contain a complete list of translations the program should process.exit(100) so we can include this in the release process and the build ill not succeed if the languages marked as released are not fully translated. This potentially makes the release process longer as more languages are added, but it means the interface won't break for anyone once a locale is released.

@adrianoBP adrianoBP changed the base branch from master to develop January 21, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

i18n locale file builder
2 participants