Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use go_json #87

Closed
wants to merge 1 commit into from
Closed

use go_json #87

wants to merge 1 commit into from

Conversation

EvilBorsch
Copy link

Hi

https://github.com/goccy/go-json is a much faster json serializer, with same interface and compatibility with encoding/json

It will be great to use it instead of encoding/json

@earthboundkid
Copy link
Owner

One of the selling points of requests is "no third party dependencies." We can't accept this as is. I think the best bet is to write a BodyGetter and a ResponseHandler in a new package and we can link to it on the Wiki for users who are interested. It would look like

err := requests.
     URL(url).
     Body(goccyreq.Body(in)).
     Handle(goccyreq.To(&out)).
     Fetch(ctx)

Not quite as nice as being built into requests, but it's manageable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants