-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authentication documentation rst file #78
Conversation
Updating from master
…this file. Still needs to be renamed.
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
====================================
Coverage 50% 50%
====================================
Files 2 2
Lines 26 26
====================================
Hits 13 13
Misses 13 13 Continue to review full report at Codecov.
|
@lwasser ready for review! |
$ abc-init | ||
|
||
.. note:: | ||
When you run ``abc-init``, you may get an error saying you have an outdated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nkorinek i'm curious about the errors that you saw here. can you provide any examples for me to better understand what is happening (just respond to this comment not in the doc). i'm trying to understand what it might need to add or update. for instance are our dependencies incorrect or out of date?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lwasser I only ran into an issue with this when I was trying to run abc-init in my base conda environment, and my papermill was not up to date enough. Once I updated papermill it ran. Not sure if this is relevant enough for people who would be installing it into the earth-analytics-python environment or the abc-dev environment. But thought I'd go on the safe side. We can take it out if need be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok got it. thank you @nkorinek !! i'll look into this a bit more tomorrow.
thank you for all of the great PR's today!!
updating from main repo
Updating from master
updating from main repo
@nkorinek i just updated the text on this PR. can you please add a changelog update to this PR and then i can merge it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just need a changelog and this is ready to merge!
@lwasser ready for merging |
beautiful!! merging @nkorinek thank you! |
Closes #74 |
Modified
github.rst
to begithub-authentication.rst
and have specific instructions for setting up github authentication withabc-classroom
.