Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication documentation rst file #78

Merged
merged 21 commits into from
Oct 10, 2019
Merged

Authentication documentation rst file #78

merged 21 commits into from
Oct 10, 2019

Conversation

nkorinek
Copy link
Member

Modified github.rst to be github-authentication.rst and have specific instructions for setting up github authentication with abc-classroom.

@codecov
Copy link

codecov bot commented Sep 26, 2019

Codecov Report

Merging #78 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #78   +/-   ##
====================================
  Coverage      50%   50%           
====================================
  Files           2     2           
  Lines          26    26           
====================================
  Hits           13    13           
  Misses         13    13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 087cb8b...973d822. Read the comment docs.

@nkorinek
Copy link
Member Author

@lwasser ready for review!

$ abc-init

.. note::
When you run ``abc-init``, you may get an error saying you have an outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nkorinek i'm curious about the errors that you saw here. can you provide any examples for me to better understand what is happening (just respond to this comment not in the doc). i'm trying to understand what it might need to add or update. for instance are our dependencies incorrect or out of date?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lwasser I only ran into an issue with this when I was trying to run abc-init in my base conda environment, and my papermill was not up to date enough. Once I updated papermill it ran. Not sure if this is relevant enough for people who would be installing it into the earth-analytics-python environment or the abc-dev environment. But thought I'd go on the safe side. We can take it out if need be.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok got it. thank you @nkorinek !! i'll look into this a bit more tomorrow.
thank you for all of the great PR's today!!

@lwasser
Copy link

lwasser commented Oct 10, 2019

@nkorinek i just updated the text on this PR. can you please add a changelog update to this PR and then i can merge it?

Copy link

@lwasser lwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just need a changelog and this is ready to merge!

@nkorinek
Copy link
Member Author

@lwasser ready for merging

@lwasser
Copy link

lwasser commented Oct 10, 2019

beautiful!! merging @nkorinek thank you!

@lwasser lwasser merged commit 50231a1 into earthlab:master Oct 10, 2019
@lwasser
Copy link

lwasser commented Oct 10, 2019

Closes #74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants