Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wradlib: Improve installation recipe when building the Docker "full" image #875

Closed
amotl opened this issue Feb 16, 2023 · 2 comments
Closed

Comments

@amotl
Copy link
Member

amotl commented Feb 16, 2023

At GH-874, we discovered that the installation of the wradlib package is performed seperately from the package version pinned in poetry.lock. This is why we we were getting a build error 1, because it installed the most recent wradlib 1.19.0, which apparently has an installation flaw (GH-876).

The issue has been quickly fixed with 2f79c5b now, but the situation should be improved by completely getting rid of the separate pip invocation. I currently can't remember why it is there. It would be better to install wradlib as a regular optional dependency of wetterdienst, right?

# Install wradlib.
RUN python -m pip install --no-cache-dir --prefer-binary --no-deps wradlib

poetry run pip install --verbose --no-input --no-deps wradlib

/cc @neumann-nico

Footnotes

  1. https://github.com/earthobservations/wetterdienst/actions/runs/4193227334/jobs/7269833277#step:7:1151

@amotl
Copy link
Member Author

amotl commented Feb 17, 2023

We've improved the situation with GH-879.

@amotl amotl closed this as completed Feb 17, 2023
@gutzbenj
Copy link
Member

gutzbenj commented Feb 17, 2023

Wradlib was previously installed decoupled of wetterdienst because it had gdal in its dependencies, and only after Kai had opted out GDAL from wradlib we were able to install it directly via pip. I had also tried to put it as is in pyproject.toml but the --no-deps option was seemingly not available there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants