Limit 1 running object file #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suchen-sci
reviewed
Aug 30, 2023
| @@ -310,10 +305,9 @@ func (or *ObjectRegistry) storeConfigInLocal(config map[string]string) { | |||
| } | |||
| buff.Write(configBuff) | |||
|
|
|||
| configLocalFileName := or.getConfigLocalFileName() | |||
| err = os.WriteFile(configLocalFileName, buff.Bytes(), 0o644) | |||
| err = os.WriteFile(or.configLocalPath, buff.Bytes(), 0o644) | |||
There was a problem hiding this comment.
Before write new running_objects.json, how about rename old one to running_objects.bak.json?
Since we remove the time from file name, how about add a timestamp to config, or use os.Chtimes(fileName, currentTime, currentTime) to change to file create time?
There was a problem hiding this comment.
Updated. Json file does not support comment, we could just use stat running_objects.json to get the time.
Codecov ReportPatch has no changes to coverable lines. ❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. 📢 Thoughts on this report? Let us know!. |
suchen-sci
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.