Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade gateway api to v1.0.0 #1129

Merged
merged 5 commits into from
Nov 7, 2023
Merged

Conversation

xxx7xxxx
Copy link
Contributor

@xxx7xxxx xxx7xxxx commented Nov 2, 2023

Have updates all dependencies to date, and fix the open-telemetry conflict[1].

[1] open-telemetry/opentelemetry-go#2341

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2023

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
pkg/cluster/config.go 94.82% <100.00%> (ø)
pkg/tracing/tracing.go 80.45% <ø> (ø)
pkg/filters/redirectorv2/redirectorv2.go 66.66% <66.66%> (ø)

... and 2 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@xxx7xxxx
Copy link
Contributor Author

xxx7xxxx commented Nov 2, 2023

The CL Lint gives error error message:

Error: SA1019: "go.opentelemetry.io/otel/exporters/jaeger" is deprecated: This module is no longer supported. OpenTelemetry dropped support for Jaeger exporter in July 2023. Jaeger officially accepts and recommends using OTLP. Use [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp] or [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc] instead. (staticcheck)

Given the official choice, we could remove Jaeger supporting since we have already supported OTLP.

@suchen-sci suchen-sci added this pull request to the merge queue Nov 7, 2023
@suchen-sci suchen-sci removed this pull request from the merge queue due to a manual request Nov 7, 2023
@suchen-sci suchen-sci added this pull request to the merge queue Nov 7, 2023
Merged via the queue into easegress-io:main with commit e98c986 Nov 7, 2023
8 checks passed
@xxx7xxxx xxx7xxxx deleted the gatewayapi-v1 branch March 12, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants