Add missing safe navigation operator #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juankiz
approved these changes
Jan 28, 2021
If the body doesn't have error or message key, the error validation fails because we try to perform `.include?` to a nil object. This adds a save navigation operator to avoid the scenario. Co-authored-by: Oscar Zatarain <ozatarain@hotmail.com>
This updates the forbidden error message to the right message sent by MercadoLibre. Co-authored-by: Oscar Zatarain <ozatarain@hotmail.com>
Co-authored-by: Oscar Zatarain <ozatarain@hotmail.com>
JuanCrg90
force-pushed
the
add_missing_safe_navigation_operator
branch
from
a777c1d
to
3f12c26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the body doesn't have error or message key, the error validation
fails because we try to perform
.include?to a nil object. Thisadds a save navigation operator to avoid the scenario. Also we added
the right response for the forbidden error.
Co-authored-by: Oscar Zatarain ozatarain@hotmail.com