Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace run_cmd with run_shell_cmd in custom easyblock for PSI/PSI4 (psi.py) #3214

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Feb 10, 2024

(created using eb --new-pr)

  • used in PSI4 easyconfigs
  • PSI easyconfigs have been archived

@branfosj
Copy link
Member Author

Test report by @branfosj

Overview of tested easyconfigs (in order)

Build succeeded for 3 out of 4 (1 easyconfigs in total)
bear-pg0105u03b - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/b4a4801abcb9dcf86f839862d3d498c5 for a full test report.

@bartoldeman
Copy link
Contributor

Seems to fail on an unrelated issue:

== 2024-02-10 10:50:34,327 build_log.py:171 ERROR EasyBuild encountered an error (at easybuild/src/easybuild-framework/easybuild/base/exceptions.py:126 in __init__): `/rds/projects/2017/branfosj-rse/easybuild/EL8-ice/software/Python/3.9.6-GCCcore-11.2.0/bin/python -m pip check` failed:
qcengine 0.26.0 requires pyyaml, which is not installed.

@branfosj
Copy link
Member Author

Checking the current install on generoso gives the same:

$ pip check
qcengine 0.26.0 requires pyyaml, which is not installed.

So, this means that pip check was not enabled before and is now. This is showing up an issue with the original easyconfig. I'll sort out a fix for it.

@branfosj
Copy link
Member Author

Updated easyconfig in easybuilders/easybuild-easyconfigs#19836

Copy link
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok with the updated easyconfig now

@bartoldeman bartoldeman merged commit adf68c3 into easybuilders:5.0.x Feb 29, 2024
17 checks passed
@branfosj branfosj deleted the 20240210100314_new_pr_psi branch February 29, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants