Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Highway 1.0.3 on some systems by disabling AVX3_DL #20298

Merged

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Apr 5, 2024

(created using eb --new-pr)

Using AVX3_DL in the baseline doesn't work in 1.0.3 causing the build to fail with

#error "Logic error: best baseline should be included in dynamic targets"

This is caused by using a wrong defined and fixed by
google/highway@f0f688b
However that the leads to a test failure:

HwyConvertTestGroup/HwyConvertTest.TestAllTruncate/AVX3_DL
u8x16 expect [0+ ->]:
0x00,0x01,0x02,0x03,0x04,0x05,0x06,
u8x16 actual [0+ ->]:
0x00,0x1A,0x02,0x1A,0x04,0x1A,0x06,
Abort at .../hwy/tests/convert_test.cc:386: AVX3_DL, u8x16 lane 1 mismatch: expected '0x01', got '0x1A'.

Hence AVX3_DL in 1.0.3 seems to be broken and must not be used.
This patch disables it by making the condition always false.

Note: Strange thing here is that this seems to have worked at some point and broke after some change possibly unrelated to EasyBuild. I guess some change in libc or so that enabled the missing defines that made Highway enable AVX3_DL

@Flamefire Flamefire changed the title Fix Highway-1.0.3-GCCcore-12.2.0 on some systems Fix Highway 1.0.3 on some systems Apr 5, 2024
@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
n1441 - Linux RHEL 8.7 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (icelake), Python 3.8.13
See https://gist.github.com/Flamefire/393a8b3181bb8f557d7880a7a8e53937 for a full test report.

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
i8022 - Linux Rocky Linux 8.7 (Green Obsidian), x86_64, AMD EPYC 7352 24-Core Processor (zen2), 8 x NVIDIA NVIDIA A100-SXM4-40GB, 545.23.08, Python 3.8.13
See https://gist.github.com/Flamefire/e62402e8e6cd36769ebd8f29079dbb0f for a full test report.

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@verdurin
Copy link
Member

Test report by @verdurin
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/verdurin/f77ce85ceacc35d8ca2c89fac50c4214 for a full test report.

@verdurin
Copy link
Member

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@verdurin: Request for testing this PR well received on login1

PR test command 'EB_PR=20298 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20298 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13287

Test results coming soon (I hope)...

- notification for comment with ID 2051932495 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/680582c29952fdb1364b6caac0ba4f14 for a full test report.

@verdurin
Copy link
Member

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@verdurin: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20298 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20298 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3944

Test results coming soon (I hope)...

- notification for comment with ID 2051965271 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/caf1f0662801d444478780114ab0a137 for a full test report.

@verdurin verdurin added this to the release after 4.9.1 milestone Apr 12, 2024
@verdurin
Copy link
Member

Going in, thanks @Flamefire!

@Flamefire
Copy link
Contributor Author

@verdurin This merge didn't go through it seems

@Flamefire
Copy link
Contributor Author

@verdurin Can you redo the merge?

@boegel boegel changed the title Fix Highway 1.0.3 on some systems Fix Highway 1.0.3 on some systems by disabling AVX3_DL Jun 8, 2024
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Jun 8, 2024

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3117.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/boegel/f8623b8054ca5ce123b03b5f8ff44460 for a full test report.

@boegel
Copy link
Member

boegel commented Jun 8, 2024

Going in, thanks @Flamefire!

@boegel boegel merged commit 164019d into easybuilders:develop Jun 8, 2024
9 checks passed
@Flamefire Flamefire deleted the 20240405090155_new_pr_Highway0122 branch June 8, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants