-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Highway 1.0.3 on some systems by disabling AVX3_DL
#20298
Fix Highway 1.0.3 on some systems by disabling AVX3_DL
#20298
Conversation
Test report by @Flamefire |
Test report by @Flamefire |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Test report by @verdurin |
@boegelbot please test @ generoso |
@verdurin: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2051932495 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
@boegelbot please test @ jsc-zen3 |
@verdurin: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2051965271 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Going in, thanks @Flamefire! |
@verdurin This merge didn't go through it seems |
@verdurin Can you redo the merge? |
AVX3_DL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Test report by @boegel |
Going in, thanks @Flamefire! |
(created using
eb --new-pr
)Using AVX3_DL in the baseline doesn't work in 1.0.3 causing the build to fail with
This is caused by using a wrong defined and fixed by
google/highway@f0f688b
However that the leads to a test failure:
Hence AVX3_DL in 1.0.3 seems to be broken and must not be used.
This patch disables it by making the condition always false.
Note: Strange thing here is that this seems to have worked at some point and broke after some change possibly unrelated to EasyBuild. I guess some change in libc or so that enabled the missing defines that made Highway enable AVX3_DL