{phys}[intel/2017a] DFTB+ v1.3.1 #4398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
requires #4336 |
|
requires manual download after (free) registration |
|
Travis test report: 8/8 runs failed - see https://travis-ci.org/hpcugent/easybuild-easyconfigs/builds/215469761 Only showing partial log for 1st failed test suite run 4112.1;
|
boegel
requested changes
Mar 27, 2017
| prebuildopts = "sed 's/ARCH = x86_64-linux-intel/ARCH = user/' Makefile.user.template > Makefile.user && " | ||
| prebuildopts += "cp sysmakes/make.x86_64-linux-intel sysmakes/make.user && " | ||
| prebuildopts += "sed -i 's|LNOPT = -static|#LNOPT = -static|' sysmakes/make.user && " | ||
| prebuildopts += "sed -i 's|/opt/intel/mkl/10.2.6.038/lib/em64t|$(MKLROOT)|' sysmakes/make.user && " |
There was a problem hiding this comment.
@migueldiascosta are these sed commands really needed? Can't you just override these values with arguments to make via buildopts?
buildopts = 'ARCH=user LNOPT= 'There was a problem hiding this comment.
you're right, simplifying
|
Travis test report: 8/8 runs failed - see https://travis-ci.org/hpcugent/easybuild-easyconfigs/builds/215583733 Only showing partial log for 1st failed test suite run 4118.1;
|
|
Test report by @migueldiascosta |
|
Test report by @migueldiascosta |
boegel
requested changes
Mar 28, 2017
| ('arpack-ng', '3.4.0'), | ||
| ] | ||
|
|
||
| subdir = '%dftbplus-%(version)s' |
There was a problem hiding this comment.
@migueldiascosta This is unused, so please remove?
| subdir = '%dftbplus-%(version)s' | ||
|
|
||
| prebuildopts = "cp sysmakes/make.x86_64-linux-intel sysmakes/make.user && " | ||
| prebuildopts += "cd prg_dftb && " |
|
Travis test report: 8/8 runs failed - see https://travis-ci.org/hpcugent/easybuild-easyconfigs/builds/215841133 Only showing partial log for 1st failed test suite run 4126.1;
|
|
Test report by @boegel |
boegel
approved these changes
Mar 31, 2017
|
lgtm |
|
Test report by @boegel |
|
Going in, thanks @migueldiascosta! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr)