Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the RPATH section check with readelf -d in sanity check optional #4249

Merged

Conversation

bedroge
Copy link
Contributor

@bedroge bedroge commented Apr 21, 2023

See easybuilders/easybuild-easyblocks#2913 and easybuilders/easybuild-easyconfigs#17516, this makes it easier for easyblocks like GoPackage to skip this check. The check is still enabled by default.

Additionally, it would be nice to have an easyconfig parameter to disable the check for individual packages (e.g. git-lfs), but that can be done in a follow-up PR.

@casparvl
Copy link
Contributor

I haven't looked in detail, but I think this PR might need a test that intentionally installs something without RPATH, and checks that it passes if this RPATH skipping option is used. (I'm assuming there already is a test that checks if the RPATH sanity check fails if the RPATH is not set, RPATH support is used, and the RPATH sanity check fails. In case that's not there, it should also be added)

@boegel boegel changed the title make the RPATH section sanity check optional make the RPATH section check with readelf -d in sanity check optional May 10, 2023
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented May 23, 2023

@casparvl You make a good point about adding a test, but all this is doing is adding support for using check_readelf_rpath=False in an easyblock when calling out to the parent sanity_check_rpath, it doesn't actually change anything at all.

Implementing a good test for this would be quite involved, and since this is blocking easybuilders/easybuild-easyblocks#2913, I'll go ahead and merge this...

@boegel boegel merged commit 47091c1 into easybuilders:develop May 23, 2023
@bedroge bedroge deleted the make_rpath_readelf_check_optional branch May 23, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants