Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve download logging #4518

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Improve download logging #4518

wants to merge 4 commits into from

Commits on Aug 8, 2024

  1. Print all URLs that would be tried in dry-run download 

    The comment about extensions doesn't really apply to the actual behavior.
So give all information we can about what would happen.
    @Flamefire
    Flamefire committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    b0661b8 View commit details
    Browse the repository at this point in the history

  2. Refactor reporting of file download 

    No need to duplicate logic of failed downloads.
    @Flamefire
    Flamefire committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    12de2cb View commit details
    Browse the repository at this point in the history

  3. Simplify check for download_instructions 

    We want to check for a true-ish value and both `None` and the empty
string are considered false, so shorten the condition
    @Flamefire
    Flamefire committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    cb42a73 View commit details
    Browse the repository at this point in the history

  4. Assemble error/warning message only once 

    Put the warning-only branch first to avoid the need for `not ...`
In both code paths the same message should be used, so do that more
clearly.
This also avoids an awkward substitution of percent signs.
    @Flamefire
    Flamefire committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    97c8199 View commit details
    Browse the repository at this point in the history