Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: on board to Docusaurus i18n system #160

Closed
Josh-Cena opened this issue Apr 6, 2022 · 1 comment · Fixed by #183
Closed

Proposal: on board to Docusaurus i18n system #160

Josh-Cena opened this issue Apr 6, 2022 · 1 comment · Fixed by #183

Comments

@Josh-Cena
Copy link

Hi, Docusaurus maintainer here!

I noticed you are using a custom translation system: https://github.com/easyops-cn/docusaurus-search-local#translations

Docusaurus now has its own i18n system, which is not too much deviated from what you have, but what's nice is that (a) you can provide OOTB theme translations and (b) users can see all text labels that need to be translated simply by running yarn write-translations.

I can't find any relevant discussion on this, so do you have plans about onboarding to the Docusaurus i18n system?

@weareoutman
Copy link
Member

Thanks for reminding, there is a conversation about this on a stale PR. However I can't squeeze in some time to make it onboard, yet :(

weareoutman added a commit that referenced this issue May 19, 2022
closes #160

BREAKING CHANGE: drop `translations` in options
weareoutman added a commit that referenced this issue May 19, 2022
closes #160

BREAKING CHANGE: drop `translations` in options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants