-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(): fix page shaking caused by quick switching menu items #476
Conversation
🚀 Deployed on https://docs-preview-476--next-bricks.netlify.app |
a62104b
to
f0ab726
Compare
bricks/nav/src/nav-menu/index.tsx
Outdated
document.body.style.overflow = event.detail ? "hidden" : ""; | ||
document.body.style.touchAction = event.detail ? "none" : ""; | ||
} | ||
}, 200); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
系统设置滚动条始终显示,然后打开这个 playgounrd,滚动条会闪烁出现
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
还有三个问题:
- 会闪烁出现水平滚动条,任何时候不应该有水平滚动条;
- 鼠标移上去后滚动条没有立即隐藏;
- 悬浮再菜单项时,快速移出再移回来,下拉菜单无法显示;
f0ab726
to
325bcb7
Compare
Refs NEXT_BUILDER-4095
325bcb7
to
92046c1
Compare
Codecov Report
@@ Coverage Diff @@
## master #476 +/- ##
==========================================
+ Coverage 80.79% 81.03% +0.24%
==========================================
Files 253 254 +1
Lines 7200 7219 +19
Branches 976 977 +1
==========================================
+ Hits 5817 5850 +33
+ Misses 1169 1157 -12
+ Partials 214 212 -2
|
Refs
NEXT_BUILDER-4095
依赖检查
组件之间的依赖声明,是微服务组件架构下的重要信息,请确保其正确性。
请勾选以下两组选项其中之一:
或者:
提交信息检查
Git 提交信息将决定包的版本发布及自动生成的 CHANGELOG,请检查工作内容与提交信息是否相符,并在以下每组选项中都依次确认。
破坏性变更:
feat
作为提交类型。BREAKING CHANGE: 你的变更说明
。新特性:
feat
作为提交类型。问题修复:
fix
作为提交类型。杂项工作:
即所有对下游使用者无任何影响、且没有必要显示在 CHANGELOG 中的改动,例如修改注释、测试用例、开发文档等:
chore
,docs
,test
等作为提交类型。