-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(): brick-next接入rum #4221
feat(): brick-next接入rum #4221
Conversation
de10900
to
5d26971
Compare
taskQueueMap.forEach((values, key) => { | ||
for (const opts of values) { | ||
ClientMonitor[key]({ | ||
...opts, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
貌似队列里的 opts 和下面调用的参数并不一样?
建议把队列直接改成缓存包装好的函数 task,然后 task 根据是否有 ClientMonitor 选择直接执行还是进入队列。这样不用在队列里去记录方法名和参数列表。
const task = () => {
ClientMonitor.setPerformance(...)
}
if (ClientMonitor) {
task();
} else {
queue.push(task);
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改了
Closes APM-996
Passing run #9794 ↗︎
Details:
Review all test suite changes for PR #4221 ↗︎ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4221 +/- ##
=======================================
Coverage 93.22% 93.23%
=======================================
Files 311 311
Lines 10250 10253 +3
Branches 1951 1951
=======================================
+ Hits 9556 9559 +3
Misses 427 427
Partials 267 267
|
Closes APM-996
依赖检查
组件之间的依赖声明,是微服务组件架构下的重要信息,请确保其正确性。
请勾选以下两组选项其中之一:
或者:
提交信息检查
Git 提交信息将决定包的版本发布及自动生成的 CHANGELOG,请检查工作内容与提交信息是否相符,并在以下每组选项中都依次确认。
破坏性变更:
feat
作为提交类型。BREAKING CHANGE: 你的变更说明
。新特性:
feat
作为提交类型。问题修复:
fix
作为提交类型。杂项工作:
即所有对下游使用者无任何影响、且没有必要显示在 CHANGELOG 中的改动,例如修改注释、测试用例、开发文档等:
chore
,docs
,test
等作为提交类型。