-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(instanceList): 增加隐藏列属性 #644
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banlijun
force-pushed
the
instanceList-hiddenColumns-1229
branch
from
December 29, 2023 08:25
3db7a24
to
5d1234d
Compare
banlijun
force-pushed
the
instanceList-hiddenColumns-1229
branch
3 times, most recently
from
January 3, 2024 07:14
14ba67c
to
60a36cf
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #644 +/- ##
==========================================
+ Coverage 85.08% 85.09% +0.01%
==========================================
Files 204 204
Lines 6918 6924 +6
Branches 1239 1239
==========================================
+ Hits 5886 5892 +6
Misses 712 712
Partials 320 320
|
banlijun
force-pushed
the
instanceList-hiddenColumns-1229
branch
2 times, most recently
from
January 3, 2024 07:56
33398b9
to
a4e8117
Compare
WHChen-Alex
reviewed
Jan 3, 2024
@@ -815,6 +814,7 @@ describe("InstanceListTable", () => { | |||
modelData={HOST} | |||
instanceListData={instanceListData} | |||
rowSelectionType="radio" | |||
hiddenColumns={[]} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
单元测试 expect一下 看看是否有效
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已赋予该属性对应测试用例
banlijun
force-pushed
the
instanceList-hiddenColumns-1229
branch
from
January 3, 2024 08:31
a4e8117
to
0362cb4
Compare
Refs NWYD-1021
banlijun
force-pushed
the
instanceList-hiddenColumns-1229
branch
from
January 3, 2024 08:33
0362cb4
to
4fc722b
Compare
WHChen-Alex
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs NWYD-1021
依赖检查
组件之间的依赖声明,是微服务组件架构下的重要信息,请确保其正确性。
请勾选以下两组选项其中之一:
或者:
提交信息检查
Git 提交信息将决定包的版本发布及自动生成的 CHANGELOG,请检查工作内容与提交信息是否相符,并在以下每组选项中都依次确认。
破坏性变更:
feat
作为提交类型。BREAKING CHANGE: 你的变更说明
。新特性:
feat
作为提交类型。问题修复:
fix
作为提交类型。杂项工作:
即所有对下游使用者无任何影响、且没有必要显示在 CHANGELOG 中的改动,例如修改注释、测试用例、开发文档等:
chore
,docs
,test
等作为提交类型。