-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev #243
dev #243
Conversation
Codecov Report
@@ Coverage Diff @@
## master #243 +/- ##
=========================================
- Coverage 57.67% 57.3% -0.38%
=========================================
Files 56 57 +1
Lines 2429 2445 +16
=========================================
Hits 1401 1401
- Misses 1028 1044 +16
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Of course these super freaky brms models will not work, neither will some rstanarm models (gamm?) for now, but the basic implementation is nice!
Can merge then (and submit?) |
I just submitted insight 0.6.0, maybe you want to wait until it's accepted on CRAN, or do you want to submit bayestestR independtly from insight? |
Can wait so we can update requirements |
last submission wasn't even a month ago, so at some point CRAN will tell you that you should submit no more often than every 1-2 months anyway ;-) |
this is a major round of update tho, after easystats is fully on CRAN the pace will (might) slow down |
Introducing new function to convert a Bayesian model into a frequentist one. Currently only support lm/glm and lmer/glmer. Could be improved.
Why? It's part of an idea for easystats/effectsize#8. At first I thought about making it an internal in parameters but then I thought, that this convenience function could be useful for people to run quick comparisons.