Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev #243

Merged
merged 4 commits into from
Oct 18, 2019
Merged

dev #243

merged 4 commits into from
Oct 18, 2019

Conversation

DominiqueMakowski
Copy link
Member

Introducing new function to convert a Bayesian model into a frequentist one. Currently only support lm/glm and lmer/glmer. Could be improved.

Why? It's part of an idea for easystats/effectsize#8. At first I thought about making it an internal in parameters but then I thought, that this convenience function could be useful for people to run quick comparisons.

DominiqueMakowski added a commit to easystats/parameters that referenced this pull request Oct 13, 2019
@codecov-io
Copy link

codecov-io commented Oct 13, 2019

Codecov Report

Merging #243 into master will decrease coverage by 0.37%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #243      +/-   ##
=========================================
- Coverage   57.67%   57.3%   -0.38%     
=========================================
  Files          56      57       +1     
  Lines        2429    2445      +16     
=========================================
  Hits         1401    1401              
- Misses       1028    1044      +16
Impacted Files Coverage Δ
R/convert_bayesian_to_frequentist.R 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d46fe0c...0cd8a04. Read the comment docs.

Copy link
Member

@strengejacke strengejacke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Of course these super freaky brms models will not work, neither will some rstanarm models (gamm?) for now, but the basic implementation is nice!

@DominiqueMakowski
Copy link
Member Author

Can merge then (and submit?)

@strengejacke
Copy link
Member

strengejacke commented Oct 17, 2019

I just submitted insight 0.6.0, maybe you want to wait until it's accepted on CRAN, or do you want to submit bayestestR independtly from insight?

@DominiqueMakowski
Copy link
Member Author

Can wait so we can update requirements

@strengejacke
Copy link
Member

last submission wasn't even a month ago, so at some point CRAN will tell you that you should submit no more often than every 1-2 months anyway ;-)

@DominiqueMakowski
Copy link
Member Author

this is a major round of update tho, after easystats is fully on CRAN the pace will (might) slow down

@strengejacke strengejacke merged commit dcb59fa into master Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants