Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fails online and in checks but not locally? #216

Open
DominiqueMakowski opened this issue Oct 18, 2022 · 2 comments
Open

Test fails online and in checks but not locally? #216

DominiqueMakowski opened this issue Oct 18, 2022 · 2 comments

Comments

@DominiqueMakowski
Copy link
Member

Super weird, this test fails on the GHA + also when I run the checks locally, but not when I directly run or reprex the code...

    library(modelbased)
    data <- iris
    data$Petal.Length_factor <- ifelse(data$Petal.Length < 4.2, "A", "B")
    model <- lme4::lmer(Sepal.Width ~ Species + (1 | Petal.Length_factor), data = data)

    estim1 <- estimate_contrasts(model, lmer.df = "satterthwaite")
#> No variable was specified for contrast estimation. Selecting `contrast = "Species"`.
    estim2 <- estimate_contrasts(model, lmer.df = "kenward-roger")
#> No variable was specified for contrast estimation. Selecting `contrast = "Species"`.
    any(estim1$CI_low != estim2$CI_low)
#> [1] TRUE

Created on 2022-10-18 by the reprex package (v2.0.1)

It's here:

test_that("estimate_contrasts - dfs", {
data <- iris
data$Petal.Length_factor <- ifelse(data$Petal.Length < 4.2, "A", "B")
model <- lme4::lmer(Sepal.Width ~ Species + (1 | Petal.Length_factor), data = data)
estim1 <- estimate_contrasts(model, lmer.df = "satterthwaite")
estim2 <- estimate_contrasts(model, lmer.df = "kenward-roger")
expect_true(any(estim1$CI_low != estim2$CI_low))
})

@IndrajeetPatil does your knowledge of the testing arcana give you some hints?

@DominiqueMakowski
Copy link
Member Author

Waaait could be that it's related to some changes in insight/parameters? But I think I'm all up to date though 🤔

@IndrajeetPatil
Copy link
Member

Let's try with devel-insight and -parameters first, and if tests still fail, I will have a look-see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants