Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN submission #221

Closed
strengejacke opened this issue Jan 11, 2023 · 15 comments
Closed

CRAN submission #221

strengejacke opened this issue Jan 11, 2023 · 15 comments

Comments

@strengejacke
Copy link
Member

@DominiqueMakowski for the forthcoming insight update, it would be good to submit modelbased first, to (hopefully) ensure a smooth submission process. Can you push a new release to CRAN?

@DominiqueMakowski
Copy link
Member

okay I'll do today

@DominiqueMakowski
Copy link
Member

submitted, what about bayestestR / report should I submit too? (sorry I'm been under water)

@DominiqueMakowski
Copy link
Member

package modelbased_0.8.5.2.tar.gz does not pass the incoming checks automatically, please see the following pre-tests:
Windows: https://win-builder.r-project.org/incoming_pretest/modelbased_0.8.5.2_20230112_025411/Windows/00check.log
Status: 1 ERROR, 1 NOTE

@DominiqueMakowski
Copy link
Member

it seems like a brms error doesn't it

@strengejacke
Copy link
Member Author

'0.8.5.2'

You submitted a dev-version 🤣

Just increase the version number to something like 0.8.3 and it should work.

@DominiqueMakowski
Copy link
Member

🙈

@strengejacke
Copy link
Member Author

submitted, what about bayestestR / report should I submit too? (sorry I'm been under water)

These are not affected by the changes in insight, I think. @vincentarelbundock testet all remaining packages and found no revdep-isuses. But if you feel it's time to submit an update for those as well, just do it. Else, there's no hurry.

@DominiqueMakowski
Copy link
Member

I'll submit otherwise all the packages I maintain are trailing behind and it looks bad 😅

@DominiqueMakowski
Copy link
Member

package modelbased_0.8.6.tar.gz does not pass the incoming checks automatically, please see the following pre-tests:
Windows: https://win-builder.r-project.org/incoming_pretest/modelbased_0.8.6_20230112_080812/Windows/00check.log
Status: 1 ERROR, 2 NOTEs

@strengejacke
Copy link
Member Author

hm, strange. Maybe skip this test for now? Honestly, it's really hassling to get stan tests working...
Also, https://cranlogs.r-pkg.org/ seems to offline / has moved? we should remove that URL from readme.

@strengejacke
Copy link
Member Author

I have updated the readme... Maybe also send to winbuilder before sending to CRAN? This will catch most of the issues during submission.

@IndrajeetPatil
Copy link
Member

cranlogs is back up and running. So you can add the links back in if you want.

@IndrajeetPatil
Copy link
Member

We should make sure that we close #216 and #219 before submission, though.

@DominiqueMakowski
Copy link
Member

package modelbased_0.8.6.tar.gz is on its way to CRAN.

@DominiqueMakowski
Copy link
Member

We should make sure that we close #216 and #219 before submission, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants