-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate sex and gender; report percentages for 3 categories each #212
Separate sex and gender; report percentages for 3 categories each #212
Conversation
…n/Woman/Non-Binary.
Thanks a lot! Can you please also adjust and update the tests here accordingly? And please also create an entry in NEWS.md to log this change. |
Hi Indrajeet,
It looks like there was to be a discussion about how to approach missing values in the test file. I hope I didn't step on any toes by making some changes. They are well commented so you can see what I did and why. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the thorough treatment.
Expect tests to fail because we still need to make some changes in master
branch.
Once @bwiernik also approves, this can be merged.
Thanks a lot @drfeinberg ! |
@bwiernik Can you please have a look at this soon? Thanks. |
Hey. If it turns out my code is useful and there are other small tasks like this that need getting done, let me know, I'm happy to help out. |
@IndrajeetPatil these changes look good to me. Could you update the tests? At some point, we should generalize this by taking a named list of matching values. That would let people do their own systems and also, eg, use terms from other languages. Would also work for race/ethnicity, occupation, major, etc. |
The tests to be updated are not relevant for this feature (those have already been updated in the PR itself), so I am merging this. |
Description
This PR aims at updating the Sex category that previously reported only the number of female participants to deal with both Sex and Gender separately, and provide 3 options each:
Sex: Female/Male/Other;
Gender: Woman/Man/Non-Binary
Proposed Changes
I added new functions for gender, changed the examples to have a gender category, and a 3rd option in each example.