Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Create an option to disable the leak sensor functionality. #26

Closed
dppeak opened this issue Jan 2, 2021 · 7 comments
Closed
Labels
enhancement New feature or request

Comments

@dppeak
Copy link

dppeak commented Jan 2, 2021

Really want to disable the leak sensor functionality. We have actual leak sensors in the house and this functionality for weather just creates confusion and worry when it shouldn't. I like the other features of the plugin, but the inability to disable (remove) the "leak" functionality, makes it where I'm going to have to find another plugin for the weather.

Thanks,
Dave

@luke-rig
Copy link

luke-rig commented Jan 3, 2021

I second this request. Love having temperature etc. It the leak sensor notifications every time it rains is a bit much

ebaauw added a commit that referenced this issue Jan 8, 2021
Add `noLeak` flag, see #26.
@ebaauw ebaauw added the enhancement New feature or request label Jan 8, 2021
@ebaauw
Copy link
Owner

ebaauw commented Jan 8, 2021

v2.4.4 introduces the noLeak config.json key to prevent updating the Leak Detected characteristic of the Leak Sensor.

@ebaauw ebaauw closed this as completed Jan 8, 2021
@ifeign
Copy link

ifeign commented Jan 10, 2021

The leak sensor still appears in the Home app even with this option selected

@ebaauw
Copy link
Owner

ebaauw commented Jan 10, 2021

Yes?

@ifeign
Copy link

ifeign commented Jan 10, 2021 via email

@ebaauw
Copy link
Owner

ebaauw commented Jan 10, 2021

No. Because all the other characteristics (visible in Eve) are on that service. It won't trigger when noLeak is set.

@luke-rig
Copy link

Thanks for adding this much better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants