Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support MariaDB driver 3.x - Illegal fetch size, batched jdbc exception translation, SqlRow blob reading #2782

Closed
Wooza opened this issue Aug 10, 2022 · 1 comment · Fixed by #2783, #2792 or #2793
Closed

Support MariaDB driver 3.x - Illegal fetch size, batched jdbc exception translation, SqlRow blob reading #2782

Wooza opened this issue Aug 10, 2022 · 1 comment · Fixed by #2783, #2792 or #2793
Assignees
@Wooza
Labels
bug
Milestone
13.8.0

Comments

@Wooza
Copy link
Contributor

Wooza commented Aug 10, 2022

Using setFetchSize(Integer.MIN_VALUE) (introduced by #56) is not allowed according to the documentation of setFetchSize:

It seems that older MariaDB drivers (<3.x.x) accepted Integer.MIN_VALUE for compatibility reasons, however the new major driver version was apparently rewritten from scratch to closely follow the JDBC specs and thus raises an exception when called with Integer.MIN_VALUE.

According to the documentation the proper solution is to use setFetchSize(1).
My current workaround is to stick with the older driver but I would really like to update.
@rbygrave
Copy link
Member

Do you want to submit a PR that bumps the jdbc driver the tests are using for MariaDB ? (that will then reproduce the problem)

@Wooza Wooza mentioned this issue Aug 10, 2022
Merged
@rbygrave rbygrave linked a pull request Aug 17, 2022 that will close this issue
Bump mariadb-java-client to 3.0.7 #2783
Merged
@rbygrave rbygrave added this to the 13.7.1 milestone Aug 17, 2022
@rbygrave rbygrave added the bug label Aug 17, 2022
@rbygrave rbygrave reopened this Aug 17, 2022
rbygrave added a commit that referenced this issue Aug 17, 2022
@rbygrave
#2782 #2783 - Forward only fetchSize() for MySql and MariaDB is Integ…
507027d 
…er.MIN_VALUE and 1 respectively
@rbygrave rbygrave linked a pull request Aug 17, 2022 that will close this issue
#2782 #2783 - Forward only fetchSize() for MySql and MariaDB is Integer.MIN_VALUE and 1 respectively #2792
Merged
rbygrave added a commit that referenced this issue Aug 17, 2022
@rbygrave
Merge pull request #2792 from ebean-orm/feature/2782-fwdOnlyFetchSize
ff45f9a 
#2782 #2783 - Forward only fetchSize() for MySql and MariaDB is Integer.MIN_VALUE and 1 respectively
rbygrave added a commit that referenced this issue Aug 17, 2022
@rbygrave
#2782 - Support MariaDB jdbc driver update - Batched JDBC SQLExceptio…
51d2f52 
…n translation, SqlRow BLOB reading

- Batched JDBC SQLException translation - Need to dig into nested exception to get cause error state
- SqlRow BLOB reading - BLOB can come as LONGVARBINARY (TestRawSqlBuilder)
- Fix test for history using system time (TestHistoryInsert)
- Fix SqlQueryCancelTest
- Fix TestSqlUpdateExceptions
@rbygrave rbygrave linked a pull request Aug 17, 2022 that will close this issue
#2782 - Support MariaDB jdbc driver update - Batched JDBC SQLException translation, SqlRow BLOB reading #2793
Merged
rbygrave added a commit that referenced this issue Aug 17, 2022
@rbygrave
Merge pull request #2793 from ebean-orm/feature/2782-mariaDb-driver-u…
6c8db9d 
…pdate

#2782 - Support MariaDB jdbc driver update - Batched JDBC SQLException translation, SqlRow BLOB reading
@rbygrave rbygrave changed the title Illegal fetch size when using most recent MariaDB driver Support MariaDB driver 3.x - Illegal fetch size, batched jdbc exception translation, SqlRow blob reading Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wooza Wooza

Labels
bug
Projects
None yet
Milestone
13.8.0
2 participants
@rbygrave @Wooza