Ensure compatibility with Nokogiri #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nokogiri v1.12 introduced a breaking change related to namespace inheritance of reparented child nodes. This commit using the feature added in v1.12.4 to opt - for new versions of Nokogiri that support it, set `Document#namespace_inheritance` - intermediate versions of Nokogiri will be avoided via gemspec version specification - old versions of Nokogiri will continue to work See sparklemotion/nokogiri#2320 for more details. Fixes ebeigarts#30
|
Nokogiri 1.12.4 is out, marking this ready for review. |
jweir
reviewed
Aug 30, 2021
There was a problem hiding this comment.
Thank you very much @flavorjones
All tests pass with nokogiri (1.12.4 x86_64-darwin) and nokogiri (1.11.7 x86_64-darwin)
|
@ebeigarts Tagging you for review. |
|
@ebeigarts please review and merge so we can use the later versions of nokogiri |
|
This has been released in v1.10.0, sorry for the delay :) |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nokogiri v1.12 introduced a breaking change related to namespace
inheritance of reparented child nodes. This commit using the feature added in
v1.12.4 to opt
Document#namespace_inheritanceSee sparklemotion/nokogiri#2320 for more details.
Fixes #30