Duck DNS dns-01 challenge handler #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Thanks for ACMESharp, it was really handy for creating a LE cert for my Duck DNS domain. Since I learned a little bit about ACMESharp, LE and Duck DNS on the way, I have created a DnsChallengeHandler for Duck DNS.
It's basically copied of the DNS Made Easy handler and adjusted to work with Duck DNS (which is as easy sending a GET request to the update endpoint). For more details, please refer to the paragraph TXT Record API at https://www.duckdns.org/spec.jsp.
I have tested this extension with a Powershell script of mine, and it works fine so far. One word of caution though: I'm not an everyday .NET programmer and I noticed the GUIDs that are spread over various places, namely the psd1 file, nugetspec and assemblyinfo. Since it is basically a copy of the DNSMadeEasy Provider, the Guids probably need to be changed, before merging it.
Thanks and keep up the good work!