Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grinder setting up down button that navigating through the known values #9

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

hsyhsw
Copy link

@hsyhsw hsyhsw commented Dec 5, 2022

I have contemplated your suggestion about using dclicker on discord chat. However, I could not figure out the generally suitable solution. So...... I'm just submitting this PR.

Here, I would illustrate my thoughts:

  • Grinder setting is a string, and dclicker provides numpad. It is inconvenient to edit the string through the on-screen numpad. For example, minus numeric value(no +/- botton on the numpad), settings with alphabet chars like forte, or someone maybe describing the grinder speed in some arbitrary form, like 1.3@1600, ...
  • Most people, at least I think, would have enough history of shots to generate their all-time used popular settings. So, I thought that the "navigating through the known values" would be more convenient when doing a dialing-in.
  • Yes, yes, these buttons are not the magic solution for making the adjustment more convenient. It may even confuse some people with non-numeric settings. but...
  • If the navigating direction of the up/down button is same as the order of the items in the selector screen, it could be quite useful.

This PR includes:

  • Up/down button navigation (following the order in the selector screen)
  • Sorting the settings if they are all numeric values (if it fails, it fall backs to the original order, order by grinder_setting sql clause.)
  • Pre-populating the known grinder settings on DYE screen loading, only once, not on poping up the selector screen. This also applies for the selector screen.

image

@hsyhsw
Copy link
Author

hsyhsw commented Dec 5, 2022

Sorry for the line endings changes in the diff...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant