Followup for PR #407 (337 bug with multiple panels) #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Illuminate\Contracts\Validation\Rule was deprecated in laravel/framework v10, should be replaced with ValidationRule once the minimum required version is 10. Signed-off-by: Tobias Grasse <tg@glancr.de>
Both `addNewMedia` and `addExistingMedia` also call `HandlesExistingMediaTrait::fillMediaCustomPropertiesFromRequest` which requires `$requestAttribute` for nested forms since 079b866 Signed-off-by: Tobias Grasse <tg@glancr.de>
Signed-off-by: Tobias Grasse <tg@glancr.de>
|
Test cases for the package are always welcome. I'm not the package creator, but only a maintainer of the package at the moment. Ebess has left the package and the package needs some love. |
|
We had to roll back the last releases due to this error until you confirm this pull request. Not able to create new media anymore because of the reason that Tobias mentions. 
Rolling back to v4.1.2 fixes the problem as expected. |
Gompje
pushed a commit
to DaktaDeo/advanced-nova-media-library
that referenced
this pull request
Mar 29, 2024
* ebess#337 Add TODO for deprecated interface Illuminate\Contracts\Validation\Rule was deprecated in laravel/framework v10, should be replaced with ValidationRule once the minimum required version is 10. Signed-off-by: Tobias Grasse <tg@glancr.de> * ebess#337 Pass requestAttribute down to media handling functions Both `addNewMedia` and `addExistingMedia` also call `HandlesExistingMediaTrait::fillMediaCustomPropertiesFromRequest` which requires `$requestAttribute` for nested forms since 079b866 Signed-off-by: Tobias Grasse <tg@glancr.de> * ebess#337 Formatting, reorder imports, add @throws tag Signed-off-by: Tobias Grasse <tg@glancr.de> --------- Signed-off-by: Tobias Grasse <tg@glancr.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, I missed two internal calls to
HandlesExistingMediaTrait:: fillMediaCustomPropertiesFromRequestwhich now requires$requestAttributeto find the custom properties on nested forms.Are there plans to add a test suite? If so, I'd be willing to contribute. https://github.com/joshgaber/NovaUnit might be a good starting point.