dcp-954 update bionetworks #530
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.submissions = {} | ||
| self.project_submissions = {} | ||
|
|
||
| def get_exported_projects(self): |
There was a problem hiding this comment.
Wouldn't it be faster to get all projects from azul, then compare it with the list of projects in ingest?
Currently we have 1025 projects registered in ingest, and there are 386 in azul, so instead of having 53 calls to ingest (I am assuming page size of 20? in api.get_all) + 1025 requests to azul, we would have 40 to azul + 53 to ingest? it would be a bit more memory-intensive since we would need to hold the list of azul projects and parse the list, but I think it would be more time efficient
Since it's a one off, this works perfectly fine, I was just wondering :)
KociOrges
approved these changes
Aug 16, 2023
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A script to update a project's bio network association.
dcp-954
ebi-ait/dcp-ingest-central#954