Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(First ever issue, delete if wrong place) Tiling system changes after 1.12 update #54

Closed
plasticmacaroni opened this issue Jan 9, 2021 · 1 comment

Comments

@plasticmacaroni
Copy link

plasticmacaroni commented Jan 9, 2021

https://ebiten.org/documents/1.12.html

Regarding the page above, I understand that rotation can affect the borders between tiles when using SubImage(). However, I am importing PNGs directly to use in tiling, with no spaces around each tile's pixels on each PNG.

Before updating to 1.12, the tiles are flush against one another (I have a simple function set that places them adjacently). After updating, the tiles in my scene appear to have small gaps, making the (black) background visible between them.

I can continue to debug what's going on here, but believe that the back-end updates to 1.12 before they're sent to the GPU are causing this behavior change.

This problem may well be PEBKAC, and I could be misunderstanding some element of vector math etc. However, to reproduce this, all I have to do is change the import from 1.11.x to 1.12.x.

If there is any advice/a particular place for me to look in order to update my code and therefore be able to update the version number, I'd love to hear any and all advice! Thank you very much :)

@hajimehoshi
Copy link
Member

(I'll transfer this issue to hajimehosh/ebiten later)

Sorry but I'm not sure what was the problem. You used your own texture atlas without gaps, and after updating to Ebiten 1.12, you saw some unexpected pixels?

@hajimehoshi hajimehoshi closed this as not planned Won't fix, can't repro, duplicate, stale Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants