Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider supporting proposed semanticHighlight notification #146

Closed
ebkalderon opened this issue Mar 4, 2020 · 2 comments
Closed

Consider supporting proposed semanticHighlight notification #146

ebkalderon opened this issue Mar 4, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@ebkalderon
Copy link
Owner

The textDocument/semanticHighlight server-to-client notification is a proposed addition to the Language Server Protocol which would allow servers to perform syntax highlighting of open text documents (upstream issue, prototype JS implementation, relevant lsp-types PR).

Since this is a proposed protocol feature currently not in the specification yet, we might need to gate it with a "proposed" feature flag, similar to what lsp-types does for the feature currently.

This feature is fairly low priority, possibly below #145, but would nonetheless be nice to have.

@oovm
Copy link

oovm commented Oct 24, 2020

I also need this, can we add the "proposed" feature?

@ebkalderon
Copy link
Owner Author

Resolved in #270 under the "semantic tokens" feature of LSP 3.16! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants