Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Physical Signal Range in XLSX Document #797

Open
ganralf75 opened this issue Jun 8, 2024 · 7 comments
Open

Physical Signal Range in XLSX Document #797

ganralf75 opened this issue Jun 8, 2024 · 7 comments
Assignees

Comments

@ganralf75
Copy link

ganralf75 commented Jun 8, 2024

Hello,

I have a stupid question regarding generation of XLSX document out of a arxml / dbc.

I have considered that when a CAN signal contains a value table (e.g. w/ 2 values ERR & SNA) the physical range (e.g. 0...1000km) of the signal is not visible in XLSX document. Instead only the values of the value table will be documented.

Example w/ value table entries ERR & SNA but missing physical range in column T
grafik

Example w/ no signal value table defined but physical range is documented
grafik

Is there any parameter that I can use so that the physical signal range will also be documented in addition to the value table entries?

thanks in advance!
ganralf75

@ganralf75 ganralf75 changed the title Physical Conversion in XLSX Document Physical Signal Range in XLSX Document Jun 8, 2024
@ebroecker
Copy link
Owner

Hi @ganralf75, this should be possible with:
--additionalSignalAttributes min,max

@ebroecker ebroecker self-assigned this Jun 21, 2024
@ganralf75
Copy link
Author

thanks a lot @ebroecker! It works :-)

@ganralf75
Copy link
Author

Hi @ebroecker! I tried --additionalSignalAttributes min,max w/ arxml file and it seems that the min and max values are not plausible. Is it a bug or did I someting wrong?

In this example signal.max should be 25.5barg
image

kind regards,
ganralf75

@ganralf75 ganralf75 reopened this Jun 22, 2024
@ebroecker
Copy link
Owner

Hi @ganralf75
not easy to say without the sources...

You could additionally add signal.factor and signal.offset - so we can see what's calculated

@ganralf75
Copy link
Author

Hi @ebroecker, I added factor and offset. Both seem to be okay.

grafik

I looks like the max is calculated from physical max (which is 25barg) and not from raw max (which is 250).

Signal configuration from Vector AUTOSAR Explorer
grafik

Signal Debugging Information
grafik

@ebroecker
Copy link
Owner

Hi @ganralf75
maybe the arxml is parsed the wrong way.
We had some issue using 'random' physical or internal contraints from 'ARXML'.

Maybe this bug is fixed with https://github.com/ebroecker/canmatrix/pull/779/files - but is not fixed right?

Maybe you could extract the contraints for this signal out of the ARXML, so we can isolate the problem ?

@pempem98
Copy link
Contributor

pempem98 commented Sep 7, 2024

Look like the physical min/max was calculated twice (initial value was calculated correctly), it would be better if we have a sample input to debug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants