Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle out of bounds access gracefully #460

Merged
merged 1 commit into from
Feb 8, 2018
Merged

Handle out of bounds access gracefully #460

merged 1 commit into from
Feb 8, 2018

Conversation

sduquej
Copy link
Contributor

@sduquej sduquej commented Feb 8, 2018

This was otherwise resulting in a:

Uncaught TypeError: Cannot read property 'record' of undefined

@GavinJoyce
Copy link
Collaborator

👍nice one @sduquej

@GavinJoyce GavinJoyce merged commit c02f5af into ebryn:master Feb 8, 2018
@sduquej sduquej deleted the sd/safe-when-out-of-bounds branch February 8, 2018 13:20
@GavinJoyce GavinJoyce mentioned this pull request Feb 8, 2018
Closed
@GavinJoyce GavinJoyce mentioned this pull request Apr 16, 2018
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sduquej @GavinJoyce