Feat/cli cdp management #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tation on the table
|
@petrovska-petro seems like this PR includes the changes from the UniV3 helpers. Do you want to rebase to that branch or perhaps claw back the UniV3 changes? |
ReviewIntroduces a script that using an address as input, outputs all of the active CDPs owned by the address with the following details for each: CDP ID, Collateral, Debt, ICR, cdp collateral vs total cdp's owned (%) and cdp debt vs total cdp's owned (%). In addition, it outputs the current ICR and price as observed by the system in real time. LGTM
Will just wait on fixes to wrong base before approving. |
|
@sajanrajdev base has being changed |
sajanrajdev
approved these changes
Feb 7, 2024
rayeaster
reviewed
Feb 13, 2024
| _, | ||
| _, | ||
| _, | ||
| ) = safe.ebtc.cdp_manager.Cdps(cdp_id) |
There was a problem hiding this comment.
here we might use getSyncedCdpCollShares() & getSyncedCdpDebt()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #7
run, sample: