-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify auto_base with C++17 parameter pack expansion in using #194
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #194 +/- ##
==========================================
- Coverage 89.91% 89.90% -0.02%
==========================================
Files 125 125
Lines 5812 5816 +4
==========================================
+ Hits 5226 5229 +3
- Misses 586 587 +1 ☔ View full report in Codecov by Sentry. |
42f9708
to
2ad85f0
Compare
this shortens the name of some tags, from adm::detail::ParameterTraits<...>::SomeTag to just SomeTag in most of the places where this is used, an unused tag type was created anyway (sometimes with the wrong name), so using that is probably clearer
the minimum cmake version is now 3.8, which is still ancient
2ad85f0
to
3642d45
Compare
todo:
no, this is still required. one possible improvement would be to flatten the list of parameters inHasParametersImpl
, so thatHasParameters<A, HasParameters<B, C>>
(as produced byVariantParameter
) is turned intoHasParameters<A, B, C>
, producing fewerCombine
classes.Flags
thingVariantParameter
usesHasParameters
, so thehas
etc. methods are overloaded, which can't be detected without knowing the parameter types