Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEMS-1.2.1 #2

Merged
merged 45 commits into from
Jun 8, 2017
Merged

NEMS-1.2.1 #2

merged 45 commits into from
Jun 8, 2017

Conversation

drishu
Copy link
Contributor

@drishu drishu commented Jun 1, 2017

No description provided.

drishu and others added 30 commits April 21, 2017 14:22
added field category field
@tatarbj
Copy link
Contributor

tatarbj commented Jun 6, 2017

The following contributed modules have issues (possibly neccessary update, missing module review, missing approval by QA team, etc):

  • admin_language from 7.x-1.0-beta1 to beta4 (available since 2016/09)
  • block_access in module review page recommends to include a patch for security reason (https://webgate.ec.europa.eu/fpfis/wikis/display/MULTISITE/Module+Review%3A+Block+Access)
  • blockreference from 7.x-2.3 to 2.4 (also ask an evaluation on it, as it seems accepted on the listing page, but not evaluated by QA team)
  • ckeditor_tabber from 7.x-1.3 to 1.4 (also ask an evaluation on it, as it seems accepted on the listing page, but not evaluated by QA team)
  • entityconnect from 7.x-1.0-rc5 to 2.0-rc1 (available since 2016/07) (also ask an evaluation on it, as it seems accepted on the listing page, but the new version is not evaluated by QA team)
  • eva from 7.x-1.2 to 1.3, also it's not accepted only on the listing page so please ask an evaluation for it by QA team.
  • features_extra - not evaluated by QA team, only accepted on the listing page.
  • feeds_xpathparser - module evaluation page doesn't exist.
  • integration - as it is available by NE platform with the same dev version, it could be reasonable to remove it from your site.make (https://github.com/ec-europa/platform-dev/blob/master/resources/multisite_drupal_standard.make#L343)
  • media_browser_plus got rejected and functionality has been promised it will be delivered in a dedicated feature: https://webgate.ec.europa.eu/fpfis/wikis/display/MULTISITE/Module+evaluation+-+Media+Browser+Plus (blocker issue)
  • media_feeds - not evaluated by QA team, only accepted on the listing page.
  • multiform - module evaluation page doesn't exist and also it could be upgraded after approval by QA team from 7.x-1.1 to 1.3 that is available since 2016/11.
  • owlcarousel - module is not evaluated by QA team, also after approval it could be upgraded from 7.x-1.5 to 1.6 tat is available since 2016/02.
  • rabbit_hole - from 7.x-2.23 to 2.24 that is available since 2017/03.
  • role_delegation - not evaluated by QA team, only accepted on the listing page.
  • views_block_filter_block - not evaluated by QA team, only accepted on the listing page.
    As it seems from the list, most of the contrib modules were not evaluated and/or has newer version than that is used on the sites and would be considerably important to evaluate the impacts of using the old versions of them.

0 => 'tid',
),
),
'locked' => 0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocker issue: Unlocked field.

0 => 'target_id',
),
),
'locked' => 0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocker issue: unlocked field.

@@ -836,3 +856,40 @@ function nems_core_preprocess_feature_set_admin_form(&$variables) {
$variables['feature_set_categories_list'] = $categories_list;
$variables['feature_set_features_list'] = $features_list;
}

/**
* template_preprocess_views_view_fields().
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong header doc format.

}

$content = $node->field_nems_core_related_content[$language->language]['0']['value'];
$content = '<div class="field-content">' . $content . '</div>';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue: $content is not sanitized. Proposal: If save_value is available use that one, or check_markup/check_plain.

* Implements hook_pathauto_alias_alter().
*/
function nems_slider_pathauto_alias_alter(&$alias, array &$context) {
// NEMS-186 pathauto setting.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation issue, please use 2 spaces.

@tatarbj tatarbj merged commit 64dd08a into ec-europa:master Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants