-
Notifications
You must be signed in to change notification settings - Fork 21
ISAICP-6694: Create the footer menus - allow moderator access #2610
base: ISAICP-6415
Are you sure you want to change the base?
Conversation
…the menu management page.
…n the installation procedures.
…link in order to insert the destination parameter.
c8064f7
to
b65b48e
Compare
id: 'system_menu_block:footer-social-media' | ||
label: 'Social media' | ||
provider: system | ||
label_display: visible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the design mockup, the Social Media menu does not have a label. We can hide it by toggling the label_display
option.
resources/runner/drupal.yml
Outdated
@@ -157,8 +157,10 @@ drupal: | |||
'config_update', | |||
'config_update_ui', | |||
'dblog', | |||
'defautl_content', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Module name is misspelled.
tests/features/site_menus.feature
Outdated
# Todo: This should become "Contact Joinup Support" in the new theme. | ||
# Ref. https://citnet.tech.ec.europa.eu/CITnet/jira/browse/ISAICP-6694 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this Todo
now.
'block-' ~ plugin_id|clean_class, | ||
'col-md-3', | ||
'col-lg-2', | ||
'about-us-menu' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still has the class from the About Us menu from which this originates. Let's update this to a unique class that can be used to identify this menu for theming purposes.
{{ page.footer }} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need to include a wrapper for the Follow Us and Social Media menus, since in the design mockup they are shown in a single column.
'col-md-3', | ||
'col-lg-2', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These classes have a meaning in Bootstrap that these elements will be shown in separate columns. We need to remove them for the Follow Us and Social Media menus, since these 2 menus will be shown together in a single column.
{% endif %} | ||
{{ title_suffix }} | ||
{% block content %} | ||
{{ content }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll have to find a solution for the links in the Social Media menu so they can be targeted individually by the frontend team to replace them with icons.
…neath the Follow us menu, and replace text links with icons.
No description provided.