Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexible reporting #1

Merged
merged 5 commits into from
Apr 27, 2022
Merged

More flexible reporting #1

merged 5 commits into from
Apr 27, 2022

Conversation

loicdtx
Copy link
Collaborator

@loicdtx loicdtx commented Apr 22, 2022

Reporting of the monitoring status was very static in the previous version. Allowing only to return the mask and disturbance_date without any option for the user to control layers returned by the .report() method. .report() now has a layers= argument which enables the user to select the desired layers.

This change breaks backward compatibility of the private ._report() method

This change alone would immediately be released in a new version (0.5.0)

@loicdtx
Copy link
Collaborator Author

loicdtx commented Apr 22, 2022

@jonasViehweger can you have a quick look at that?

@jonasViehweger
Copy link
Contributor

jonasViehweger commented Apr 26, 2022

Looks good to me. My only suggestion is this line to add the names of the layers as band names to the tif.
I tested it and it should work as is.

loicdtx and others added 2 commits April 27, 2022 12:45
Co-authored-by: jonasViehweger <53001455+jonasViehweger@users.noreply.github.com>
@loicdtx loicdtx merged commit 9b0bea4 into master Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants