Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python to major version only in setup.py #20

Closed
wants to merge 1 commit into from

Conversation

AdamRJensen
Copy link
Contributor

It's common practice to just list the major version of python as the minor version soon get outdated.

@loicdtx
Copy link
Collaborator

loicdtx commented Jul 24, 2024

Thank you for the suggestion @AdamRJensen, I mostly disagree though. Not a big deal, these classifier are 'just' for indexing purpose on pypi, but as the zen of python says, "explicit is better than implicit" 😉

When in doubt I refer to how widely acclaimed packages are handling it; see for instance rasterio and requests

@loicdtx loicdtx closed this Jul 24, 2024
@AdamRJensen
Copy link
Contributor Author

Fair point, I see that matplotlib and pandas do both, i.e., have both 'just Python 3' and the minor versions listed

@loicdtx
Copy link
Collaborator

loicdtx commented Jul 29, 2024

Yes, that's also what I did in 48a3f48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants