Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secp256k1 updated to v4 #256

Merged
merged 6 commits into from
Nov 17, 2022
Merged

secp256k1 updated to v4 #256

merged 6 commits into from
Nov 17, 2022

Conversation

e-asphyx
Copy link
Contributor

Update secp256k1 to version having correct curve name

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 15, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 16fbd85
Status: ✅  Deploy successful!
Preview URL: https://57874e64.signatory.pages.dev
Branch Preview URL: https://fix-sec256k1-version.signatory.pages.dev

View logs

@danielelisi
Copy link
Contributor

Integration tests are failing due to the Octez binaries being renamed. I've merged #260 so I'll rebase this PR on current master

@codeclimate
Copy link

codeclimate bot commented Nov 15, 2022

Code Climate has analyzed commit 16fbd85 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 46.6% (0.0% change).

View more on Code Climate.

@AbineshECAD
Copy link
Contributor

Transaction successful with the imported azure secp256k1 key.
INFO[0026] GET /authorized_keys duration="580.7µs" hostname="localhost:6732" method=GET path=/authorized_keys start_time="2022-11-16T19:00:32+05:30" status=200 INFO[0026] Requesting signing operation ops="map[reveal:1 transaction:1]" ops_total=2 pkh=tz2PeYw5zJS3Q2aXd2zuQbjs4MTbwmvCQ6tg request=generic vault=Azure vault_name="https://sigy.vault.azure.net/" INFO[0026] About to sign raw bytes ops="map[reveal:1 transaction:1]" ops_total=2 pkh=tz2PeYw5zJS3Q2aXd2zuQbjs4MTbwmvCQ6tg raw=03ecf855ffdc6638bdf9532721585e9cae160a9a9742892045b87bbd5bf8e6eda66b01a8310ad8214ec822867e95136b44ce7cb5751834e8029de601e80700010287ea0b20e3a932e4363ef521f5d03b9f6c28f4e4aca5eb1db7b7ebcf3dd79da46c01a8310ad8214ec822867e95136b44ce7cb575183482029ee601e9070080ade2040002f846b9ed8834c257a6f0c3cebeab4f58508b20ad00 request=generic vault=Azure vault_name="https://sigy.vault.azure.net/" INFO[0028] Signed generic successfully ops="map[reveal:1 transaction:1]" ops_total=2 pkh=tz2PeYw5zJS3Q2aXd2zuQbjs4MTbwmvCQ6tg request=generic vault=Azure vault_name="https://sigy.vault.azure.net/" INFO[0028] POST /keys/tz2PeYw5zJS3Q2aXd2zuQbjs4MTbwmvCQ6tg duration=1.911840721s hostname="localhost:6732" method=POST path=/keys/tz2PeYw5zJS3Q2aXd2zuQbjs4MTbwmvCQ6tg start_time="2022-11-16T19:00:32+05:30" status=200

@danielelisi danielelisi merged commit cd47445 into main Nov 17, 2022
@danielelisi danielelisi deleted the fix-sec256k1-version branch November 17, 2022 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants