Skip to content

Commit

Permalink
upgrade alpine to 3.18
Browse files Browse the repository at this point in the history
Force intl v73.1 on CI that we use the same version.
There is a breaking change between the default intl (icu) version on
the CI and the alpine image used.
Don't update the intl package automatically because this could not be achieved by @BacLuc until now.

Issue: #3246
  • Loading branch information
usu authored and BacLuc committed May 18, 2023
1 parent 78e17eb commit fdeeb7c
Show file tree
Hide file tree
Showing 8 changed files with 12 additions and 17 deletions.
1 change: 1 addition & 0 deletions .github/workflows/continuous-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ jobs:
- uses: shivammathur/setup-php@v2
with:
php-version: '8.2.6'
extensions: intl-73.1
tools: composer:2.5.0
coverage: xdebug

Expand Down
2 changes: 1 addition & 1 deletion api/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
ARG PHP_VERSION=8.2.6

# renovate: datasource=docker depName=alpine
ARG ALPINE_VERSION=3.16
ARG ALPINE_VERSION=3.18

# renovate: datasource=docker depName=caddy
ARG CADDY_VERSION=2.6.4
Expand Down
2 changes: 1 addition & 1 deletion api/tests/Api/Camps/CreateCampTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ public function testCreateCampValidatesInvalidPeriods() {
'violations' => [
[
'propertyPath' => 'periods[0].start',
'message' => 'This value should be less than or equal to Jan 8, 2022, 12:00 AM.',
'message' => 'This value should be less than or equal to Jan 8, 2022, 12:00AM.',
],
],
]);
Expand Down
4 changes: 2 additions & 2 deletions api/tests/Api/Periods/CreatePeriodTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -265,11 +265,11 @@ public function testCreatePeriodValidatesStartAfterEnd() {
'violations' => [
[
'propertyPath' => 'start',
'message' => 'This value should be less than or equal to Jan 9, 2021, 12:00 AM.',
'message' => 'This value should be less than or equal to Jan 9, 2021, 12:00AM.',
],
[
'propertyPath' => 'end',
'message' => 'This value should be greater than or equal to Jan 10, 2021, 12:00 AM.',
'message' => 'This value should be greater than or equal to Jan 10, 2021, 12:00AM.',
],
],
]);
Expand Down
4 changes: 2 additions & 2 deletions api/tests/Api/Periods/UpdatePeriodTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -274,11 +274,11 @@ public function testPatchPeriodValidatesStartAfterEnd() {
'violations' => [
[
'propertyPath' => 'start',
'message' => 'This value should be less than or equal to Jan 9, 2021, 12:00 AM.',
'message' => 'This value should be less than or equal to Jan 9, 2021, 12:00AM.',
],
[
'propertyPath' => 'end',
'message' => 'This value should be greater than or equal to Jan 10, 2021, 12:00 AM.',
'message' => 'This value should be greater than or equal to Jan 10, 2021, 12:00AM.',
],
],
]);
Expand Down
4 changes: 2 additions & 2 deletions api/tests/Api/ScheduleEntries/CreateScheduleEntryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ public function testCreateScheduleEntryValidatesStartBeforePeriodStart() {
'violations' => [
[
'propertyPath' => 'start',
'message' => 'This value should be greater than or equal to May 1, 2023, 12:00 AM.',
'message' => 'This value should be greater than or equal to May 1, 2023, 12:00AM.',
],
],
]);
Expand All @@ -177,7 +177,7 @@ public function testCreateScheduleEntryValidatesNegativeLength() {
'violations' => [
[
'propertyPath' => 'end',
'message' => 'This value should be greater than May 1, 2023, 1:30 AM.',
'message' => 'This value should be greater than May 1, 2023, 1:30AM.',
],
],
]);
Expand Down
6 changes: 3 additions & 3 deletions api/tests/Api/ScheduleEntries/UpdateScheduleEntryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ public function testPatchScheduleEntryValidatesStartBeforePeriodStart() {
'violations' => [
[
'propertyPath' => 'start',
'message' => 'This value should be greater than or equal to May 1, 2023, 12:00 AM.',
'message' => 'This value should be greater than or equal to May 1, 2023, 12:00AM.',
],
],
]);
Expand Down Expand Up @@ -224,7 +224,7 @@ public function testPatchScheduleEntryValidatesNegativeLength() {
'violations' => [
[
'propertyPath' => 'end',
'message' => 'This value should be greater than May 1, 2023, 12:40 AM.',
'message' => 'This value should be greater than May 1, 2023, 12:40AM.',
],
],
]);
Expand Down Expand Up @@ -264,7 +264,7 @@ public function testPatchScheduleEntryValidatesEndAfterPeriodEnd() {
'violations' => [
[
'propertyPath' => 'end',
'message' => 'This value should be less than or equal to May 4, 2023, 12:00 AM.',
'message' => 'This value should be less than or equal to May 4, 2023, 12:00AM.',
],
],
]);
Expand Down
6 changes: 0 additions & 6 deletions renovate.json
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,6 @@
],
"versioning": "regex:^(?<major>\\d+)\\.(?<minor>\\d+)\\.(?<patch>\\d+)-(?<compatibility>\\w+)-(?<build>\\d+)\\.(\\d+)\\.(\\d+)?$"
},
{
"matchPackageNames": [
"alpine"
],
"allowedVersions": "3.16"
},
{
"matchPackageNames": [
"postgres"
Expand Down

0 comments on commit fdeeb7c

Please sign in to comment.