Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve frontend startup without pdf service running #3783

Merged
merged 3 commits into from
Sep 17, 2023

Conversation

manuelmeister
Copy link
Member

@manuelmeister manuelmeister commented Sep 15, 2023

I had the following errors:

✘ [ERROR] ENOENT: no such file or directory, open '/home/ecamp3/frontend/src/pdf/prepareInMainThread.mjs' [plugin vite:dep-scan]

    src/components/print/print-client/generatePdf.js:1:36:
      1 │ import { prepareInMainThread } from '@/pdf/prepareInMainThread.mjs'
✘ [ERROR] ENOENT: no such file or directory, open '/app/src/pdf/pdf.mjs' [plugin vite:dep-scan]

   src/components/print/print-client/renderPdf.js:3:32:
     3 │ import { render, prepare } from '@/pdf/pdf.mjs'

The missing files, pdf.mjs and prepareInMainThread.mjs, caused the problem due to a new repository installation where I forgot to run the client-side pdf service.

To help beginners, I have created a placeholder that gives a helpful suggestion instead of generating a vite error, and it is now possible to run the frontend without having to build the client-side pdf code.

To guide beginners to the correct package, all package.json names have been made consistent. Also the version field has been removed as it is not used and is unmaintained. Additionally they have been marked private.

translation/package.json Show resolved Hide resolved
@carlobeltrame carlobeltrame added the deploy! Creates a feature branch deployment for this PR label Sep 15, 2023
@carlobeltrame carlobeltrame temporarily deployed to feature-branch September 15, 2023 13:46 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Sep 15, 2023

Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

@manuelmeister manuelmeister temporarily deployed to feature-branch September 15, 2023 14:08 — with GitHub Actions Inactive
@BacLuc
Copy link
Contributor

BacLuc commented Sep 17, 2023

Could you please squash c6654dc
and 1df5114
That we don't have files in an ignored directory appear and disappear in the history.

What was the goal of changing the name and removing the version of our npm packages in the repo?
Could you mention the change and the reason in the PR description?

- Make name more unique to easier reference the package
- Remove unused and unmaintained version number
- Mark packages as private as they are not published on npm
… run yet

Signed-off-by: Manuel Meister <news.manuelsworld@gmail.com>
@manuelmeister manuelmeister changed the title Improve/noob docker startup Improve frontend startup without pdf service running Sep 17, 2023
@manuelmeister manuelmeister temporarily deployed to feature-branch September 17, 2023 11:29 — with GitHub Actions Inactive
@manuelmeister
Copy link
Member Author

@BacLuc done

@manuelmeister manuelmeister added this pull request to the merge queue Sep 17, 2023
Merged via the queue into ecamp:devel with commit 788763e Sep 17, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy! Creates a feature branch deployment for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants