-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve frontend startup without pdf service running #3783
Merged
manuelmeister
merged 3 commits into
ecamp:devel
from
manuelmeister:improve/noob-docker-startup
Sep 17, 2023
Merged
Improve frontend startup without pdf service running #3783
manuelmeister
merged 3 commits into
ecamp:devel
from
manuelmeister:improve/noob-docker-startup
Sep 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlobeltrame
approved these changes
Sep 15, 2023
carlobeltrame
temporarily deployed
to
feature-branch
September 15, 2023 13:46
— with
GitHub Actions
Inactive
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
manuelmeister
temporarily deployed
to
feature-branch
September 15, 2023 14:08
— with
GitHub Actions
Inactive
manuelmeister
force-pushed
the
improve/noob-docker-startup
branch
from
September 17, 2023 11:18
65d78e5
to
5c35cc2
Compare
- Make name more unique to easier reference the package - Remove unused and unmaintained version number - Mark packages as private as they are not published on npm
… run yet Signed-off-by: Manuel Meister <news.manuelsworld@gmail.com>
manuelmeister
force-pushed
the
improve/noob-docker-startup
branch
from
September 17, 2023 11:22
5c35cc2
to
c68e64c
Compare
manuelmeister
changed the title
Improve/noob docker startup
Improve frontend startup without pdf service running
Sep 17, 2023
manuelmeister
temporarily deployed
to
feature-branch
September 17, 2023 11:29
— with
GitHub Actions
Inactive
@BacLuc done |
BacLuc
approved these changes
Sep 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had the following errors:
The missing files,
pdf.mjs
andprepareInMainThread.mjs
, caused the problem due to a new repository installation where I forgot to run the client-side pdf service.To help beginners, I have created a placeholder that gives a helpful suggestion instead of generating a vite error, and it is now possible to run the frontend without having to build the client-side pdf code.
To guide beginners to the correct package, all package.json names have been made consistent. Also the version field has been removed as it is not used and is unmaintained. Additionally they have been marked private.